Skip to content

fixes error highlighting when selecting an error in another tab #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

joshgiesbrecht
Copy link
Contributor

@joshgiesbrecht joshgiesbrecht commented May 20, 2025

Fixes #1112

Current code finds start/end of highlight by finding char offsets based on the error's given line number; however, it's looking at the visible tab to do so, making the highlighting go wonky if you're selecting an error in a tab you don't have open yet.

Added one line to switch active tab before we find the char offsets.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fixes bug with selecting an error that's in a tab that isn't visible yet.
@Stefterv Stefterv added this to the 4.4.5 milestone May 22, 2025
@SableRaf SableRaf merged commit a58a7a7 into processing:main Jul 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect highlighting when selecting an error from the list that's in a different tab
3 participants